Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential voltage transition

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential voltage transition
Date	2016-11-15 18:40 +0100
Message-ID	<sDPSa-7Wd-19@gated-at.bofh.it> (permalink)
References	<szQWu-4TL-19@gated-at.bofh.it> <sDrG9-p6-15@gated-at.bofh.it> <sDKz7-4pA-17@gated-at.bofh.it> <sDMUh-65N-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 15 November 2016 07:57 PM, Rob Herring wrote:
> On Tue, Nov 15, 2016 at 5:42 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> On Monday 14 November 2016 09:18 PM, Rob Herring wrote:
>>> On Fri, Nov 04, 2016 at 11:07:54PM +0530, Laxman Dewangan wrote:
>>>>
>>>> regulator
>>>>    +- pwm-regulator-voltage-ramp-time-us: Integer, voltage ramp time in
>>> This is a really long name. Drop the 'pwm-regulator-' part as it is
>>> redundant. The fact that it is PWM reg specific is captured as it is
>>> documented that way.
>>>
>> We already have the regulator-ramp-delay from the regulator core.
>> Just wanted to make this (pwm-regulator-voltage-ramp-time-us) for pwm
>> specific.
> Neither of these are very clear that one is linear and one is
> exponential. Maybe you should use the existing property to express the
> time and just add a boolean property like "voltage-ramp-exponential"?

OK, this can work.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential  voltage transition Rob Herring <robh@kernel.org> - 2016-11-14 16:50 +0100
  Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential  voltage transition Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-15 13:00 +0100
    Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential  voltage transition Rob Herring <robh@kernel.org> - 2016-11-15 15:30 +0100
      Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential  voltage transition Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-15 18:40 +0100

csiph-web