Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
Date	2016-11-15 17:00 +0100
Message-ID	<sDOjo-6QT-23@gated-at.bofh.it> (permalink)
References	<sAUEF-5ny-5@gated-at.bofh.it> <sAUOl-5sm-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> > Nothing in this header file depends on <linux/types.h>.
> > Rather, <linux/errno.h> should be included for -ENODEV.
> 
> So how do we end up with a definition for u32?
> 
> I think you need both these include files.

I've noticed you haven't responded to the above.

I've discarded the patch you've placed in the patch system in the hope
of a replacement with this comment addressed.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of  <linux/types.h> Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-15 17:00 +0100

csiph-web