Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1522906

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options
Date 2016-11-15 17:40 +0100
Message-ID <sDOW6-7mP-29@gated-at.bofh.it> (permalink)
References <sDMUh-65N-7@gated-at.bofh.it> <sDMUh-65N-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote:
> On some platforms, energy efficient ethernet with rtl8211 devices is
> causing issue, like throughput drop or broken link.
> 
> This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root
> cause is not fully understood yet, disabling EEE advertisement prevent auto
> negotiation from enabling EEE.
> 
> This patch provides options to disable 1000T and 100TX EEE advertisement
> individually for the realtek phys supporting this feature.

Looking at the code, i don't see anything specific to RealTek
here. This all seems generic. So should it be in phy.c and made a
generic OF property which can be applied to any PHY which supports
EEE.

      Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net 0/3] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-15 15:30 +0100
  [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-15 15:30 +0100
    Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable  options Andrew Lunn <andrew@lunn.ch> - 2016-11-15 17:40 +0100
      Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable  options Florian Fainelli <f.fainelli@gmail.com> - 2016-11-15 18:10 +0100
        Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement  disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-16 11:00 +0100
          Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable  options Andrew Lunn <andrew@lunn.ch> - 2016-11-16 14:30 +0100
            Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement  disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-16 16:00 +0100
              Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable  options Andrew Lunn <andrew@lunn.ch> - 2016-11-16 16:10 +0100
                Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement  disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-16 16:40 +0100
                Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable  options Florian Fainelli <f.fainelli@gmail.com> - 2016-11-16 18:10 +0100
    Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Anand Moon <linux.amoon@gmail.com> - 2016-11-16 18:10 +0100
      Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement  disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-17 11:30 +0100
        Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Anand Moon <linux.amoon@gmail.com> - 2016-11-17 19:10 +0100
          Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement  disable options Jerome Brunet <jbrunet@baylibre.com> - 2016-11-17 22:50 +0100
  [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek phys Jerome Brunet <jbrunet@baylibre.com> - 2016-11-15 15:40 +0100
    Re: [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek  phys Rob Herring <robh@kernel.org> - 2016-11-16 16:20 +0100
      Re: [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek  phys Jerome Brunet <jbrunet@baylibre.com> - 2016-11-16 16:30 +0100
  [PATCH net 3/3] ARM64: dts: meson: odroidc2: disable 1000t-eee advertisement Jerome Brunet <jbrunet@baylibre.com> - 2016-11-15 15:40 +0100

csiph-web