Re: [PATCH V7 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V7 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only
Date	2016-11-15 16:30 +0100
Message-ID	<sDNQl-6Go-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <stxMR-7wa-7@gated-at.bofh.it> <stEOm-3Fs-33@gated-at.bofh.it> <suGXM-5ph-15@gated-at.bofh.it> <sDrZw-Nx-5@gated-at.bofh.it> <sDH8d-2s4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 15 Nov 2016 16:14:29 +0800
Chunyan Zhang <zhang.chunyan@linaro.org> wrote:

>
> > Then why have a
> >
> >         if (export->write)
> >
> >
> > Is there every going to be a case where export will not have a write
> > function?  
> 
> There shouldn't be.
> 
> I can move this if statement to the register_ftrace_export() to ensure
> users won't wrongly use it, that's saying the write() of trace_export
> has been set before being registered to 'ftrace_exports_list'.
> 

Looks like it's already there:

+int register_ftrace_export(struct trace_export *export)
+{
+	if (WARN_ON_ONCE(!export->write))
+		return -1;


-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V7 1/3] tracing: add a possibility of exporting function  trace to other places instead of ring buffer only Steven Rostedt <rostedt@goodmis.org> - 2016-11-14 17:10 +0100
  Re: [PATCH V7 1/3] tracing: add a possibility of exporting function  trace to other places instead of ring buffer only Chunyan Zhang <zhang.chunyan@linaro.org> - 2016-11-15 09:20 +0100
    Re: [PATCH V7 1/3] tracing: add a possibility of exporting function  trace to other places instead of ring buffer only Steven Rostedt <rostedt@goodmis.org> - 2016-11-15 16:30 +0100

csiph-web