Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522753

[PATCH] nvmem: qfprom: Fix to support single byte read/write

Show all headers | View raw

The nvmem core driver supports to read and write single
byte. This helps in extracting a required value based
on bit-offset and number of bits for the required value
in the nvmem cell.

Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
---

Based on torvalds's master branch.

 - Tested on db410c for thermal sensors, and
   on db820c for qusb2 phy with tree [1] based on linaro qcom landing
   team's integration tree.

[1] https://github.com/vivekgautam1/linux/tree/linaro/integration-linux-qcomlt-qcom-phy-upstream

 drivers/nvmem/qfprom.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index b5305f0..2bdb6c3 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -21,11 +21,11 @@ static int qfprom_reg_read(void *context,
 			unsigned int reg, void *_val, size_t bytes)
 {
 	void __iomem *base = context;
-	u32 *val = _val;
-	int i = 0, words = bytes / 4;
+	u8 *val = _val;
+	int i = 0, words = bytes;
 
 	while (words--)
-		*val++ = readl(base + reg + (i++ * 4));
+		*val++ = readb(base + reg + i++);
 
 	return 0;
 }
@@ -34,11 +34,11 @@ static int qfprom_reg_write(void *context,
 			 unsigned int reg, void *_val, size_t bytes)
 {
 	void __iomem *base = context;
-	u32 *val = _val;
-	int i = 0, words = bytes / 4;
+	u8 *val = _val;
+	int i = 0, words = bytes;
 
 	while (words--)
-		writel(*val++, base + reg + (i++ * 4));
+		writeb(*val++, base + reg + i++);
 
 	return 0;
 }
@@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
 static struct nvmem_config econfig = {
 	.name = "qfprom",
 	.owner = THIS_MODULE,
-	.stride = 4,
+	.stride = 1,
 	.word_size = 1,
 	.reg_read = qfprom_reg_read,
 	.reg_write = qfprom_reg_write,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvmem: qfprom: Fix to support single byte read/write Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-15 15:10 +0100
  Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write Stephen Boyd <sboyd@codeaurora.org> - 2016-11-15 20:00 +0100
    Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-16 05:40 +0100
      Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write Stephen Boyd <sboyd@codeaurora.org> - 2016-11-16 23:30 +0100
        [PATCH v2] nvmem: qfprom: Allow single byte accesses for read/write Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-17 07:10 +0100

csiph-web