Re: [PATCH] HID: udraw-ps3: accel_limits is local to the driver

From	Bastien Nocera <hadess@hadess.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: udraw-ps3: accel_limits is local to the driver
Date	2016-11-15 14:40 +0100
Message-ID	<sDM7T-5vB-9@gated-at.bofh.it> (permalink)
References	<sDLYe-5sD-27@gated-at.bofh.it> <sDLYe-5sD-29@gated-at.bofh.it> <sDLYe-5sD-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-11-15 at 14:26 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> And as such should be marked static to avoid global namespace
> pollution.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Yes, thanks.

Reviewed-by: Bastien Nocera <hadess@hadess.net>

> ---
> 
> I've just applied this on top of hid.git#for-4.10/udraw-ps3
> 
>  drivers/hid/hid-udraw-ps3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-udraw-ps3.c b/drivers/hid/hid-udraw-
> ps3.c
> index 1f68b0b..88ea390 100644
> --- a/drivers/hid/hid-udraw-ps3.c
> +++ b/drivers/hid/hid-udraw-ps3.c
> @@ -54,7 +54,7 @@ enum {
>   * Accelerometer min/max values
>   * in order, X, Y and Z
>   */
> -struct {
> +static struct {
>         int min;
>         int max;
>  } accel_limits[] = {
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: udraw-ps3: accel_limits is local to the driver Jiri Kosina <jikos@kernel.org> - 2016-11-15 14:30 +0100
  Re: [PATCH] HID: udraw-ps3: accel_limits is local to the driver Bastien Nocera <hadess@hadess.net> - 2016-11-15 14:40 +0100

csiph-web