Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522732

Re: [PATCH 2/3] x86/intel_rdt: Return state to default on umount

Show all headers | View raw

On Fri, 11 Nov 2016, Fenghua Yu wrote:
> @@ -801,6 +801,7 @@ static void rmdir_all_sub(void)
>  {
>  	struct rdtgroup *rdtgrp, *tmp;
>  	struct task_struct *p, *t;
> +	int cpu;
>  
>  	/* move all tasks to default resource group */
>  	read_lock(&tasklist_lock);
> @@ -819,10 +820,19 @@ static void rmdir_all_sub(void)
>  		/* Remove each rdtgroup other than root */
>  		if (rdtgrp == &rdtgroup_default)
>  			continue;
> +
> +		/* Give any CPUs back to the default group */
> +		cpumask_or(&rdtgroup_default.cpu_mask,
> +			   &rdtgroup_default.cpu_mask, &rdtgrp->cpu_mask);

That's a pointless exercise. We can simply copy cpu_online_mask to the
default group mask and be done with it. I'll fix that up.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] x86/intel_rdt: Fix kernfs_to_rdtgroup to know about "info/*" directories "Fenghua Yu" <fenghua.yu@intel.com> - 2016-11-12 02:10 +0100
  [PATCH 2/3] x86/intel_rdt: Return state to default on umount "Fenghua Yu" <fenghua.yu@intel.com> - 2016-11-12 02:10 +0100
    Re: [PATCH 2/3] x86/intel_rdt: Return state to default on umount Thomas Gleixner <tglx@linutronix.de> - 2016-11-15 14:40 +0100
      Re: [PATCH 2/3] x86/intel_rdt: Return state to default on umount Thomas Gleixner <tglx@linutronix.de> - 2016-11-15 18:40 +0100
    [tip:x86/cache] x86/intel_rdt: Reset per cpu closids on unmount tip-bot for Fenghua Yu <tipbot@zytor.com> - 2016-11-15 18:50 +0100
  [PATCH 3/3] x86/intel_rdt: Update closid in PQR_ASSOC registers in synchronous mode when changing "cpus" "Fenghua Yu" <fenghua.yu@intel.com> - 2016-11-12 02:10 +0100
    Re: [PATCH 3/3] x86/intel_rdt: Update closid in PQR_ASSOC registers  in synchronous mode when changing "cpus" Thomas Gleixner <tglx@linutronix.de> - 2016-11-15 14:50 +0100
    Re: [PATCH 3/3] x86/intel_rdt: Update closid in PQR_ASSOC registers  in synchronous mode when changing "cpus" Thomas Gleixner <tglx@linutronix.de> - 2016-11-15 15:10 +0100
      Re: [PATCH 3/3] x86/intel_rdt: Update closid in PQR_ASSOC registers  in synchronous mode when changing "cpus" Thomas Gleixner <tglx@linutronix.de> - 2016-11-15 17:50 +0100
    [tip:x86/cache] x86/intel_rdt: Update percpu closid immeditately on  CPUs affected by changee tip-bot for Fenghua Yu <tipbot@zytor.com> - 2016-11-15 18:50 +0100
  [tip:x86/cache] x86/intel_rdt: Protect info directory from removal tip-bot for Fenghua Yu <tipbot@zytor.com> - 2016-11-15 18:50 +0100

csiph-web