Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522730

Re: [PATCH RESEND] phy: exynos-mipi-video: simplify check for coupled phy status

Show all headers | View raw

On Monday 07 November 2016 04:18 PM, Marek Szyprowski wrote:
> There is no need to access regmap of coupled phy to check its state - such
> information is already in the phy device itself, so use it directly. This
> let us to avoid possible access to registers of the device in the disabled
> power domain if the coupled phy is already disabled.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

merged to phy -next.

Thanks
Kishon
> ---
>  drivers/phy/phy-exynos-mipi-video.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index 8b851f7..6bee04c 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -229,19 +229,6 @@ struct exynos_mipi_video_phy {
>  	spinlock_t slock;
>  };
>  
> -static inline int __is_running(const struct exynos_mipi_phy_desc *data,
> -			struct exynos_mipi_video_phy *state)
> -{
> -	u32 val;
> -	int ret;
> -
> -	ret = regmap_read(state->regmaps[data->resetn_map], data->resetn_reg, &val);
> -	if (ret)
> -		return 0;
> -
> -	return val & data->resetn_val;
> -}
> -
>  static int __set_phy_state(const struct exynos_mipi_phy_desc *data,
>  			   struct exynos_mipi_video_phy *state, unsigned int on)
>  {
> @@ -251,7 +238,7 @@ static int __set_phy_state(const struct exynos_mipi_phy_desc *data,
>  
>  	/* disable in PMU sysreg */
>  	if (!on && data->coupled_phy_id >= 0 &&
> -	    !__is_running(state->phys[data->coupled_phy_id].data, state)) {
> +	    state->phys[data->coupled_phy_id].phy->power_count == 0) {
>  		regmap_read(state->regmaps[data->enable_map], data->enable_reg,
>  			    &val);
>  		val &= ~data->enable_val;
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] phy: exynos-mipi-video: simplify check for coupled  phy status Kishon Vijay Abraham I <kishon@ti.com> - 2016-11-15 14:40 +0100

csiph-web