[PATCH 1/2] v4l2-tpg: Init hv_enc field with a valid value

From	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] v4l2-tpg: Init hv_enc field with a valid value
Date	2016-11-15 13:10 +0100
Message-ID	<sDKIO-4KT-35@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Zero is not a valid value for hsv_enc. Set the field to a valid
initial value.

This is not a problem for vivid, because it sets the field to 180 via
tpg_s_hsv_enc() on the control initialization, but it might be a source
of errors for other drivers that use this code.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
index 28d7b072d867..e47b46e2d26c 100644
--- a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
+++ b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
@@ -117,6 +117,7 @@ void tpg_init(struct tpg_data *tpg, unsigned w, unsigned h)
 	tpg_s_fourcc(tpg, V4L2_PIX_FMT_RGB24);
 	tpg->colorspace = V4L2_COLORSPACE_SRGB;
 	tpg->perc_fill = 100;
+	tpg->hsv_enc = V4L2_HSV_ENC_180;
 }
 EXPORT_SYMBOL_GPL(tpg_init);
 
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] v4l2-tpg: Init hv_enc field with a valid value Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-11-15 13:10 +0100
  [PATCH 2/2] vivid: Set color_enc on HSV formats Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-11-15 13:10 +0100

csiph-web