Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522510

Re: [PATCH 1/2] ARM: dts: da850: add the mstpri and ddrctl nodes

Show all headers | View raw

On Monday 14 November 2016 11:02 PM, Bartosz Golaszewski wrote:
> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
> controller drivers to da850.dtsi.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  arch/arm/boot/dts/da850.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 1bb1f6d..1635218 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -440,6 +440,11 @@
>  			interrupts = <52>;
>  			status = "disabled";
>  		};
> +
> +		mstpri: mstpri@14110 {
> +			compatible = "ti,da850-mstpri";
> +			reg = <0x14110 0x0c>;
> +		};

Instead of adding the node to the end, can you place it above the
cfgchip node to keep it sorted by reg. We have not really followed that
in this file. May be we should have. But lets start with this.

>  	};
>  	aemif: aemif@68000000 {
>  		compatible = "ti,da850-aemif";
> @@ -451,4 +456,8 @@
>  			  1 0 0x68000000 0x00008000>;
>  		status = "disabled";
>  	};
> +	ddrctl: ddrctl@b0000000 {
> +		compatible = "ti,da850-ddr-controller";
> +		reg = <0xb0000000 0xe8>;
> +	};

Can you name the node memory-controller@b0000000? Thats the generic name
suggested by ePAPR 1.1 for memory controllers.

I could not find any naming suggestions for the bus master priority
controller above, but based on the pattern used for other controllers,
may be it should be called priority-controller@14110 instead of mstpri@14110

Thanks,
Sekhar

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ARM: da850: enable the MSTPRI and DDR2/mDDR drivers Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-14 18:40 +0100
  [PATCH 1/2] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-14 18:40 +0100
    Re: [PATCH 1/2] ARM: dts: da850: add the mstpri and ddrctl nodes Sekhar Nori <nsekhar@ti.com> - 2016-11-15 11:10 +0100
  [PATCH 2/2] ARM: davinci_all_defconfig: enable the mstpri and ddrctl drivers Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-14 18:40 +0100
    Re: [PATCH 2/2] ARM: davinci_all_defconfig: enable the mstpri and  ddrctl drivers Sekhar Nori <nsekhar@ti.com> - 2016-11-15 11:20 +0100

csiph-web