Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1522446
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc |
| Date | 2016-11-15 09:50 +0100 |
| Message-ID | <sDHBf-2C3-29@gated-at.bofh.it> (permalink) |
| References | <sDBct-6Lx-3@gated-at.bofh.it> <sDBct-6Lx-5@gated-at.bofh.it> <sDHhU-2vk-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 15, 2016 at 08:25:55AM +0000, Chris Wilson wrote:
> On Tue, Nov 15, 2016 at 10:57:35AM +0900, Gustavo Padovan wrote:
> > /**
> > + * dma_crtc_fence_ops - fence ops for the drm_crtc timeline
> > + *
> > + * It contains the dma_fence_ops that should be called by the dma_fence
> > + * code. CRTC core should use this ops when initializing fences.
> > + */
> > +extern const struct dma_fence_ops drm_crtc_fence_ops;
> > +
> > +static inline struct drm_crtc *fence_to_crtc(struct dma_fence *fence)
> > +{
> > + BUG_ON(fence->ops != &drm_crtc_fence_ops);
> > + return container_of(fence->lock, struct drm_crtc, fence_lock);
> > +}
>
> If you are planning to export this for use by drivers, you are missing
> the EXPORT_SYMBOL(drm_crtc_fence_ops).
My suggestion would not to have the BUG_ON() here (saves one
checkpatch.pl complaint in exchange for a slightly more mysterious GPF).
Also please consider calling this dma_fence_to_crtc() as otherwise it
conflicts with those with plans to use struct fences on their
crtc/states.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v11 0/3] drm: add explicit fencing Gustavo Padovan <gustavo@padovan.org> - 2016-11-15 03:00 +0100
[PATCH v11 1/3] drm/fence: add in-fences support Gustavo Padovan <gustavo@padovan.org> - 2016-11-15 03:00 +0100
[PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Gustavo Padovan <gustavo@padovan.org> - 2016-11-15 03:00 +0100
Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Chris Wilson <chris@chris-wilson.co.uk> - 2016-11-15 09:30 +0100
Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Chris Wilson <chris@chris-wilson.co.uk> - 2016-11-15 09:50 +0100
Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Gustavo Padovan <gustavo@padovan.org> - 2016-11-15 09:50 +0100
Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Daniel Vetter <daniel@ffwll.ch> - 2016-11-15 10:00 +0100
Re: [PATCH v11 2/3] drm/fence: add fence timeline to drm_crtc Chris Wilson <chris@chris-wilson.co.uk> - 2016-11-15 10:00 +0100
[PATCH v11 3/3] drm/fence: add out-fences support Gustavo Padovan <gustavo@padovan.org> - 2016-11-15 03:00 +0100
csiph-web