Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1522354

Re: kvm: WARNING in em_jmp_far

From Dmitry Vyukov <dvyukov@google.com>
Newsgroups linux.kernel
Subject Re: kvm: WARNING in em_jmp_far
Date 2016-11-15 06:40 +0100
Message-ID <sDEDn-I6-9@gated-at.bofh.it> (permalink)
References <sDEal-vS-1@gated-at.bofh.it> <sDEDn-I6-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Nov 15, 2016 at 6:24 AM, Nadav Amit <nadav.amit@gmail.com> wrote:
>
>> On Nov 14, 2016, at 9:06 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
>>
>> Hello,
>>
>> The following program triggers WARNING in em_jmp_far:
>> https://gist.githubusercontent.com/dvyukov/16bfd3d68fa7d5461101ef74e07796e4/raw/e6d663980681f2c5838ff6cd361cede7d3204838/gistfile1.txt
>>
>>
>> WARNING: CPU: 1 PID: 15748 at arch/x86/kvm/emulate.c:2128 em_jmp_far+0x4a7/0x530
>
> I don’t know how to “read” the test, but it seems that this warning
> can be triggered if CS base/limit cause a #GP exception when EIP
> is loaded.
>
> I think it safe to remove this warning (which I introduced) as well as
> the redundant “return rc” that follows it. The code should handle the
> emulation correctly regardless of the warning.

There was also a similar WARNING in em_ret_far:
https://groups.google.com/forum/#!msg/syzkaller/o5ZftARBhrs/r1ivQ-HtBgAJ

Please mail a fix and add a test.

Thanks

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

kvm: WARNING in em_jmp_far Dmitry Vyukov <dvyukov@google.com> - 2016-11-15 06:10 +0100
  Re: kvm: WARNING in em_jmp_far Nadav Amit <nadav.amit@gmail.com> - 2016-11-15 06:40 +0100
    Re: kvm: WARNING in em_jmp_far Dmitry Vyukov <dvyukov@google.com> - 2016-11-15 06:40 +0100
      Re: kvm: WARNING in em_jmp_far Nadav Amit <nadav.amit@gmail.com> - 2016-11-15 06:40 +0100
        Re: kvm: WARNING in em_jmp_far Paolo Bonzini <pbonzini@redhat.com> - 2016-11-15 11:50 +0100

csiph-web