Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522331

Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted

Show all headers | View raw

On Mon, Nov 14, 2016 at 03:44:58PM -0800, Jarkko Sakkinen wrote:
> Use atomic bitops for chip->flags so that we do not need chip->is_open
> and chip->duration_adjusted anymore.

I don't know if it s a really great idea to use atomic bit ops for
things that do not need to be atomic.. It makes the locking scheme
less clear. is open is genuinely different since it relies on the
atomic for correctness.

Merging is_duration makes lots of sense though

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 00:50 +0100
  Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-15 05:40 +0100
    Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 06:20 +0100
      Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-16 06:30 +0100
        Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-17 00:00 +0100
  Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and  chip->duration_adjusted Nayna <nayna@linux.vnet.ibm.com> - 2016-11-17 11:50 +0100
    Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and  chip->duration_adjusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-17 18:40 +0100

csiph-web