Re: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback

From	wlf <wulf@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback
Date	2016-11-15 04:30 +0100
Message-ID	<sDCBz-7So-9@gated-at.bofh.it> (permalink)
References	<sDjyV-3JZ-5@gated-at.bofh.it> <sDjyW-3JZ-19@gated-at.bofh.it> <sDu1k-25s-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Doug,

在 2016年11月15日 02:15, Doug Anderson 写道:
> William
>
> On Sun, Nov 13, 2016 at 11:01 PM, William Wu <wulf@rock-chips.com> wrote:
>> Since we needs to delay ~1ms to wait for 480MHz output clock
>> of USB2 PHY to become stable after turn on it, the delay time
>> is pretty long for something that's supposed to be "atomic"
>> like a clk_enable(). Consider that clk_enable() will disable
>> interrupt and that a 1ms interrupt latency is not sensible.
>>
>> The 480MHz output clock should be handled in prepare callbacks
>> which support gate a clk if the operation may sleep.
>>
>> Signed-off-by: William Wu <wulf@rock-chips.com>
>> ---
>>   drivers/phy/phy-rockchip-inno-usb2.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks! I'll add  Reviewed-by.
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu <wulf@rock-chips.com> - 2016-11-14 08:10 +0100
  Re: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback Doug Anderson <dianders@google.com> - 2016-11-14 19:20 +0100
    Re: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback wlf <wulf@rock-chips.com> - 2016-11-15 04:30 +0100

csiph-web