Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522281

Re: [PATCH] virtio_ring: fix description of virtqueue_get_buf

Show all headers | View raw

On 2016年11月14日 22:16, Felipe Franciosi wrote:
> The device (not the driver) populates the used ring and includes the len
> of how much data was written.
>
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> ---
>   drivers/virtio/virtio_ring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 489bfc6..8a0d6a9 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -649,7 +649,7 @@ static inline bool more_used(const struct vring_virtqueue *vq)
>    * @vq: the struct virtqueue we're talking about.
>    * @len: the length written into the buffer
>    *
> - * If the driver wrote data into the buffer, @len will be set to the
> + * If the device wrote data into the buffer, @len will be set to the
>    * amount written.  This means you don't need to clear the buffer
>    * beforehand to ensure there's no data leakage in the case of short
>    * writes.

Reviewed-by: Jason Wang <jasowang@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] virtio_ring: fix description of virtqueue_get_buf Felipe Franciosi <felipe@nutanix.com> - 2016-11-14 15:30 +0100
  Re: [PATCH] virtio_ring: fix description of virtqueue_get_buf Jason Wang <jasowang@redhat.com> - 2016-11-15 04:30 +0100

csiph-web