Groups > linux.kernel > #1520178

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier
Date	Sat, 12 Nov 2016 06:20:02 +0100
Message-ID	<sCyTo-653-3@gated-at.bofh.it> (permalink)
References	<sChfQ-35W-17@gated-at.bofh.it> <sChfQ-35W-15@gated-at.bofh.it> <sCs1A-1sJ-25@gated-at.bofh.it>
X-Original-To	"Rafael J. Wysocki" <rafael@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ts4pGDzve4FeKRsQrzEqJbh8leTNs9ML1WoVXLZ+DnY=; b=Fpp0ZCGa89twkS8mHiaFtGqFuZuOhybfQxvUrjkv3V4eSyRTSrrDQxL+8a+j0geeC6 Kbjrup206xKwxQ6WOluK+qw2BFcAuQnShh6d0k1mTWCV4zJSTXfRU6WMhNPlOKiuc/nd KCJSRfq3JOsVxcAy7HLbtOU71EXOvZeADhMtM=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ts4pGDzve4FeKRsQrzEqJbh8leTNs9ML1WoVXLZ+DnY=; b=I9CAWGkLnhOjiiAnyejQpL0ZfkUTktjbgKN2kxY+NxSYk2AgW34dQl/XIynRhT+d/Z B1GtuQwOL2+HrrIxoHHe24i6InH3+glWOi8BlPwB+8BEVeeumZqQ74okmW7wkyhPd/IH 2I2TJnN0YYhOtJThbXKiL2mplpKWJ1VpKYwoScd9q06v5TgJAy7IhJFNAUmbebzMrz5A OYWX/Pde8E9VQpTvCIq5tbRRSmXDRg2GTRQdl+vkprzYGyjvnuK5Y+difbfoHqFvckEw wmcZPH5fxTMquhyPZFA1RMIXQs0gZckvG8TrwW3sov9RvOYRNzbElIlupizo5n4twt26 KYpA==
X-Gm-Message-State	ABUngveNKPOtcarIymuwjJ1iwygdzZJ9c7X9rTltBnuVHWKKNzrT2vTMe+QswGuUoBNmP0zM1FRR79elCJvDZ8ht
X-Received	by 10.55.5.149 with SMTP id 143mr6703892qkf.236.1478927981655; Fri, 11 Nov 2016 21:19:41 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	Rafael Wysocki <rjw@rjwysocki.net>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Lists linaro-kernel <linaro-kernel@lists.linaro.org>, Linux PM <linux-pm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Vincent Guittot <vincent.guittot@linaro.org>, Juri Lelli <Juri.Lelli@arm.com>, Robin Randhawa <robin.randhawa@arm.com>
X-Original-Date	Sat, 12 Nov 2016 10:49:41 +0530
X-Original-Message-ID	<CAKohponvq3vuzNvaGE7_Pn8vM54AMPZu_E8yRyeytegh-bjuzQ@mail.gmail.com>
X-Original-References	<cover.1478858983.git.viresh.kumar@linaro.org> <1acfffe798c0371e69ec1171f485499e7b49ed6d.1478858983.git.viresh.kumar@linaro.org> <CAJZ5v0gMDoLrdCqxnyUQqWydqj6Ot0ssf=P9=hOk_bOG9gCi0Q@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1520178

Show key headers only | View raw

On 12 November 2016 at 03:28, Rafael J. Wysocki <rafael@kernel.org> wrote:

>> @@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy)
>>         struct sugov_tunables *tunables = sg_policy->tunables;
>>         unsigned int count;
>>
>> -       cpufreq_disable_fast_switch(policy);
>> -
>
> ->but why is this change necessary?
>
> sugov_stop() has been called already, so the ordering here shouldn't matter.

Because sugov_policy_free() would be using the flag fast_switch_enabled.

--
viresh

Thread

[PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-11 11:30 +0100
  Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Peter Zijlstra <peterz@infradead.org> - 2016-11-11 15:30 +0100
    Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-11 23:00 +0100
      Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Peter Zijlstra <peterz@infradead.org> - 2016-11-12 00:00 +0100
  Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-11 23:00 +0100
    Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-12 06:20 +0100
      Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-13 15:50 +0100
        Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-14 05:20 +0100
          Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-14 12:40 +0100

csiph-web