Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1520162

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps
Date 2016-11-12 03:30 +0100
Message-ID <sCweR-4kN-9@gated-at.bofh.it> (permalink)
References <s5LnX-4sk-3@gated-at.bofh.it> <s61Cq-7hw-25@gated-at.bofh.it> <s61Cq-7hw-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sat, 2016-08-13 at 20:30 +0200, Florian Westphal wrote:
> Ben Hutchings <ben@decadent.org.uk> wrote:
> > 3.16.37-rc1 review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Florian Westphal <fw@strlen.de>
> > 
> > commit 36472341017529e2b12573093cc0f68719300997 upstream.
> 
> [..]
> 
> > The extra overhead is negible, even with absurd cases.
> 
> Not true, the overhead is huge and increases restore time for
> large rulesets from mere seconds to minutes, see
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi
> t/?id=f4dc77713f8016d2e8a3295e1c9c53a21f296def

I've queued both of these up for the next update.

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of  jumps Ben Hutchings <ben@decadent.org.uk> - 2016-11-12 03:30 +0100

csiph-web