Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1520159

Re: [PATCH] Security: selinux - Improvement in code readability when

Show all headers | View raw

On Fri, Nov 11, 2016 at 3:48 AM, Shailendra Verma
<shailendra.v@samsung.com> wrote:
> From: "Shailendra Verma" <shailendra.v@samsung.com>
>
> There is no need to call kfree() if memdup_user() fails, as no memory
> was allocated and the error in the error-valued pointer should be returned.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
>  security/selinux/selinuxfs.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Hello Shailendra,

Thank you for your patch, but I prefer the readability of the code as
it currently stands.

-- 
paul moore
www.paul-moore.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Security: selinux - Improvement in code readability when Shailendra Verma <shailendra.v@samsung.com> - 2016-11-11 10:00 +0100
  Re: [PATCH] Security: selinux - Improvement in code readability when Paul Moore <paul@paul-moore.com> - 2016-11-12 03:30 +0100

csiph-web