Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1520092

Re: [PATCH 0/3] perf tools: Plug jvmti compilation into perf build

Show all headers | View raw

Jiri,

On Wed, Nov 2, 2016 at 6:35 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> hi,
> adding jvmti compilation under perf build, so it's easy
> to put it under rpm.
>
> I plan on updating fedora/rhel perf rpm, to have the jvmti
> placed in like:
>
>   $ rpm -qpl build/x86_64/perf-4.8.5-300.fc24.x86_64.rpm | grep jvmti
>   /usr/lib64/libperf-jvmti.so
>
> Stephane,
> I'm keeping the jvmti/Makefile as I dont fully follow
> the need for .lo objects. Please let me know if you'd
> be ok with this new way of building jvmti lib.
>
Tested the patch on x86_64. With and without NO_JVMTI.
Tried the libperf-jvmti.so on existing test case, got correct results.

I believe you can now remove the jvmti/Makefile, it is not needed
anymore. We must always (and only) build the .so as this library
is meant to be used as a Java agent.

Tested-by: Stephane Eranian <eranian@google.com>

> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/fixes
>
> thanks,
> jirla
>
>
> ---
> Jiri Olsa (3):
>       tools build: Add CFLAGS_REMOVE_* support
>       tools build: Add jvmti feature detection support
>       perf tools: Plug jvmti compilation into perf build
>
>  tools/build/Build.include           |  4 +++-
>  tools/build/Documentation/Build.txt |  6 ++++--
>  tools/build/feature/Makefile        |  6 +++++-
>  tools/build/feature/test-jvmti.c    | 13 +++++++++++++
>  tools/perf/Makefile.config          | 26 ++++++++++++++++++++++++++
>  tools/perf/Makefile.perf            | 24 +++++++++++++++++++++++-
>  tools/perf/jvmti/Build              |  8 ++++++++
>  tools/perf/tests/make               |  2 +-
>  8 files changed, 83 insertions(+), 6 deletions(-)
>  create mode 100644 tools/build/feature/test-jvmti.c
>  create mode 100644 tools/perf/jvmti/Build

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] perf tools: Plug jvmti compilation into perf build Jiri Olsa <jolsa@kernel.org> - 2016-11-02 14:40 +0100
  Re: [PATCH 0/3] perf tools: Plug jvmti compilation into perf build Jiri Olsa <jolsa@redhat.com> - 2016-11-11 11:00 +0100
    Re: [PATCH 0/3] perf tools: Plug jvmti compilation into perf build Stephane Eranian <eranian@google.com> - 2016-11-11 16:20 +0100
  Re: [PATCH 0/3] perf tools: Plug jvmti compilation into perf build Stephane Eranian <eranian@google.com> - 2016-11-12 00:20 +0100
    [PATCH] perf tools: Remove jvmti/Makefile file Jiri Olsa <jolsa@redhat.com> - 2016-11-12 13:20 +0100
      [tip:perf/core] perf kvmti: Remove unused Makefile file tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-11-15 11:50 +0100

csiph-web