Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519917
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 3/3] drm/fence: add out-fences support |
| Date | 2016-11-11 18:20 +0100 |
| Message-ID | <sCnEC-7ay-13@gated-at.bofh.it> (permalink) |
| References | <sCkQp-5qC-17@gated-at.bofh.it> <sCl9M-5wV-23@gated-at.bofh.it> <sCnbz-6LA-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Nov 11, 2016 at 11:48:09AM -0500, Sean Paul wrote:
> On Fri, Nov 11, 2016 at 9:15 AM, Gustavo Padovan <gustavo@padovan.org> wrote:
> > +static void complete_crtc_signaling(struct drm_device *dev,
> > + struct drm_atomic_state *state,
> > + struct drm_out_fence_state *fence_state,
> > + unsigned int num_fences, int ret)
> > +{
> > + struct drm_crtc *crtc;
> > + struct drm_crtc_state *crtc_state;
> > + int i;
> > +
> > + if (!ret) {
>
> I don't think there's any reason to smash the fd install and clean-up
> into one function. I think splitting into 2 functions and calling the
> right one from atomic_ioctl would be better.
Hm, I suggested this because the control flow in one of Gustavo's earlier
patches look really funny. I guess it could be split up again, but with
both callers in the current position. tbh I don't care whether it's this
or that, both are clear improvement over the older version.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 0/3] drm: add explict fencing Gustavo Padovan <gustavo@padovan.org> - 2016-11-11 15:40 +0100
[PATCH v8 2/3] drm/fence: add fence timeline to drm_crtc Gustavo Padovan <gustavo@padovan.org> - 2016-11-11 15:40 +0100
[PATCH v8 1/3] drm/fence: add in-fences support Gustavo Padovan <gustavo@padovan.org> - 2016-11-11 15:40 +0100
Re: [PATCH v8 1/3] drm/fence: add in-fences support Sean Paul <seanpaul@google.com> - 2016-11-11 16:50 +0100
[PATCH v8 3/3] drm/fence: add out-fences support Gustavo Padovan <gustavo@padovan.org> - 2016-11-11 15:40 +0100
Re: [PATCH v8 3/3] drm/fence: add out-fences support Sean Paul <seanpaul@chromium.org> - 2016-11-11 17:50 +0100
Re: [PATCH v8 3/3] drm/fence: add out-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-11-11 18:20 +0100
Re: [PATCH v8 3/3] drm/fence: add out-fences support Sean Paul <seanpaul@chromium.org> - 2016-11-11 18:30 +0100
Re: [PATCH v8 3/3] drm/fence: add out-fences support Brian Starkey <brian.starkey@arm.com> - 2016-11-11 18:40 +0100
Re: [PATCH v8 0/3] drm: add explict fencing Robert Foss <robert.foss@collabora.com> - 2016-11-11 16:00 +0100
csiph-web