Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519759
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] spi: spi-fsl-dspi: Add DMA support for Vybrid |
| Date | 2016-11-11 13:30 +0100 |
| Message-ID | <sCj7X-4hu-13@gated-at.bofh.it> (permalink) |
| References | <sBWEq-6aV-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Nov 10, 2016 at 05:49:15PM +0530, Sanchayan Maity wrote: A couple of small things, please send followup patches fixing them. > + rx_word = is_double_byte_mode(dspi); > + > + len = rx_word ? (dma->curr_xfer_len / 2) : dma->curr_xfer_len; Please use normal if statements, they're much easier to read. > +err_slave_config: > + devm_kfree(dev, dma->rx_dma_buf); > +err_rx_dma_buf: > + devm_kfree(dev, dma->tx_dma_buf); You really shouldn't need to explicitly free things like this if you're using devm_, especially in the error path from the probe function like this where a failure is just going to result in the device failing to instantiate so you won't have the allocation sitting around unused for any length of time.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] spi: spi-fsl-dspi: Add DMA support for Vybrid Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-10 13:30 +0100
Re: [PATCH v3] spi: spi-fsl-dspi: Add DMA support for Vybrid Mark Brown <broonie@kernel.org> - 2016-11-11 13:30 +0100
[PATCH 3/4] spi: spi-fsl-dspi: Fix continuous selection format Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-17 19:30 +0100
Re: [PATCH 3/4] spi: spi-fsl-dspi: Fix continuous selection format Stefan Agner <stefan@agner.ch> - 2016-11-18 02:20 +0100
Re: [PATCH 3/4] spi: spi-fsl-dspi: Fix continuous selection format maitysanchayan@gmail.com - 2016-11-18 09:10 +0100
[PATCH 1/4] spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-17 19:30 +0100
Re: [PATCH 1/4] spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE Stefan Agner <stefan@agner.ch> - 2016-11-18 02:00 +0100
Applied "spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE" to the spi tree Mark Brown <broonie@kernel.org> - 2016-11-21 20:30 +0100
[PATCH 0/4] Fixes for Vybrid SPI DMA implementation Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-17 19:50 +0100
[PATCH 2/4] spi: spi-fsl-dspi: Fix incorrect DMA setup Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-17 19:50 +0100
Re: [PATCH 2/4] spi: spi-fsl-dspi: Fix incorrect DMA setup Stefan Agner <stefan@agner.ch> - 2016-11-18 02:10 +0100
Re: [PATCH 2/4] spi: spi-fsl-dspi: Fix incorrect DMA setup maitysanchayan@gmail.com - 2016-11-18 09:20 +0100
Re: [PATCH 2/4] spi: spi-fsl-dspi: Fix incorrect DMA setup Stefan Agner <stefan@agner.ch> - 2016-11-19 00:50 +0100
[PATCH 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes Sanchayan Maity <maitysanchayan@gmail.com> - 2016-11-17 20:00 +0100
Applied "spi: spi-fsl-dspi: Add DMA support for Vybrid" to the spi tree Mark Brown <broonie@kernel.org> - 2016-11-11 14:10 +0100
csiph-web