Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519738
| From | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 09/12] fs: logfs: convert to bio_add_page() in sync_request() |
| Date | 2016-11-11 13:10 +0100 |
| Message-ID | <sCiOC-48t-15@gated-at.bofh.it> (permalink) |
| References | <sCiOC-48t-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Always bio_add_page() is the standard and preferred way to do the task. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <tom.leiming@gmail.com> --- fs/logfs/dev_bdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index dc8cafeee038..e01075790600 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -20,13 +20,9 @@ static int sync_request(struct page *page, struct block_device *bdev, int op) struct bio_vec bio_vec; bio_init(&bio, &bio_vec, 1); - bio_vec.bv_page = page; - bio_vec.bv_len = PAGE_SIZE; - bio_vec.bv_offset = 0; - bio.bi_vcnt = 1; bio.bi_bdev = bdev; + bio_add_page(&bio, page, PAGE_SIZE, 0); bio.bi_iter.bi_sector = page->index * (PAGE_SIZE >> 9); - bio.bi_iter.bi_size = PAGE_SIZE; bio_set_op_attrs(&bio, op, 0); return submit_bio_wait(&bio); -- 2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 09/12] fs: logfs: convert to bio_add_page() in sync_request() Ming Lei <tom.leiming@gmail.com> - 2016-11-11 13:10 +0100
csiph-web