Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519664

Re: [PATCH 2/2] mm: THP page cache support for ppc64

Show all headers | View raw

On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote:
> @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct page *page)
>  	ret = VM_FAULT_FALLBACK;
>  	page = compound_head(page);
>  
> +	/*
> +	 * Archs like ppc64 need additonal space to store information
> +	 * related to pte entry. Use the preallocated table for that.
> +	 */
> +	if (arch_needs_pgtable_deposit() && !fe->prealloc_pte)
> +		fe->prealloc_pte = pte_alloc_one(vma->vm_mm, fe->address);
> +

-ENOMEM handling?

I think we should do this way before this point. Maybe in do_fault() or
something.

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-11-07 09:40 +0100
  [PATCH 2/2] mm: THP page cache support for ppc64 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-11-07 09:40 +0100
    Re: [PATCH 2/2] mm: THP page cache support for ppc64 "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-11 11:20 +0100
      Re: [PATCH 2/2] mm: THP page cache support for ppc64 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-11-11 13:20 +0100
        Re: [PATCH 2/2] mm: THP page cache support for ppc64 "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-11 17:30 +0100
          Re: [PATCH 2/2] mm: THP page cache support for ppc64 Hugh Dickins <hughd@google.com> - 2016-11-12 02:40 +0100
  Re: [PATCH 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-11-07 10:20 +0100
  Re: [PATCH 1/2] mm: move vma_is_anonymous check within  pmd_move_must_withdraw kbuild test robot <lkp@intel.com> - 2016-11-07 10:30 +0100
    Re: [PATCH 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-11-07 12:50 +0100
    [PATCH V2] mm: move vma_is_anonymous check within pmd_move_must_withdraw "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-11-07 15:50 +0100
      Re: [PATCH V2] mm: move vma_is_anonymous check within  pmd_move_must_withdraw "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-11 11:10 +0100

csiph-web