Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519607

Re: [PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it is a config map

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Nov 11, 2016 at 10:35:10AM +0800, Chen-Yu Tsai wrote:
> In the recently refactored sunxi pinctrl library, we are only allocating
> one set of pin configs for each pinmux setting node. When the pinctrl_map
> structure is freed, the pin configs should also be freed. However the
> code assumed the first map would contain the configs, which actually
> never happens, as the mux function map gets added first.
> 
> The proper way to do this is to look through all the maps and free the
> first one whose type is actually PIN_MAP_TYPE_CONFIGS_GROUP.
> 
> Also slightly expand the comment explaining this.
> 
> Fixes: f233dbca6227 ("pinctrl: sunxi: Rework the pin config building code")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it is a config map Chen-Yu Tsai <wens@csie.org> - 2016-11-11 03:40 +0100
  Re: [PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it  is a config map Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-11 09:30 +0100
  Re: [PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it is  a config map Linus Walleij <linus.walleij@linaro.org> - 2016-11-15 10:20 +0100

csiph-web