Groups > linux.kernel > #1519605

Re: [patch] usb: xhci-mem: use passed in GFP flags instead of GFP_KERNEL

From	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [patch] usb: xhci-mem: use passed in GFP flags instead of GFP_KERNEL
Date	2016-11-11 09:30 +0100
Message-ID	<sCfnH-1SI-15@gated-at.bofh.it> (permalink)
References	<sC3mx-29W-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-11-10 22:33:17 [+0300], Dan Carpenter wrote:
> We normally use the passed in gfp flags for allocations, it's just these
> two which were missed.

You seem to be right. xhci_mem_init() has only one caller with
GFP_KERNEL as argument. You could unwind it.

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

> Fixes: 22d45f01a836 ("usb/xhci: replace pci_*_consistent() with dma_*_coherent()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] usb: xhci-mem: use passed in GFP flags instead of GFP_KERNEL Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-10 20:40 +0100
  Re: [patch] usb: xhci-mem: use passed in GFP flags instead of  GFP_KERNEL Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-11 09:30 +0100

csiph-web