Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1520335

[PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset call

From Brian Masney <masneyb@onstation.org>
Newsgroups linux.kernel
Subject [PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset call
Date 2016-11-12 19:30 +0100
Message-ID <sCLdT-5L4-23@gated-at.bofh.it> (permalink)
References <sCLdT-5L4-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The entries in the lux table (als_device_lux) can be updated via sysfs
through the function in_illuminance_lux_table_store(). The last row in
the table must be terminated with values that are zero. The sysfs code
already ensures that the last row is all zeros. The call to memset to
clear out the table is not needed so this patch removes the unnecessary
call.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/tsl2583.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index 9db191f..712f753 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -591,9 +591,6 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
 		goto done;
 	}
 
-	/* Zero out the table */
-	memset(chip->als_settings.als_device_lux, 0,
-	       sizeof(chip->als_settings.als_device_lux));
 	memcpy(chip->als_settings.als_device_lux, &value[1],
 	       value[0] * sizeof(value[1]));
 
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset call Brian Masney <masneyb@onstation.org> - 2016-11-12 19:30 +0100

csiph-web