Groups > linux.kernel > #1520244

Re: [PATCH 2/2] staging: iio: ad7606: move out of staging

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: iio: ad7606: move out of staging
Date	2016-11-12 15:30 +0100
Message-ID	<sCHtD-3dB-7@gated-at.bofh.it> (permalink)
References	<sCdFf-JU-1@gated-at.bofh.it> <sCdFf-JU-7@gated-at.bofh.it> <sCl05-5tz-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/11/16 14:22, Lars-Peter Clausen wrote:
> On 11/11/2016 07:34 AM, Eva Rachel Retuya wrote:
>> Move the ad7606 driver from staging/iio/adc to iio/adc. Also, update the
>> corresponding Makefile and Kconfig associated with the change.
> 
> This is obviously OK, but when you generate a patch that moves files use
> `git format-patch -M ...`. This will generate a more compact patch.
> 
I tend to make an exception for staging graduation patches.
The mere posting of the whole driver by not using the move detection
makes for really easy review of whether we have forgotten something
else that needs cleanup before the graduation.

Most of the time -M is much more sensible!

Jonathan

Thread

[PATCH 0/2] staging: iio: ad7606: move driver out of staging Eva Rachel Retuya <eraretuya@gmail.com> - 2016-11-11 07:40 +0100
  [PATCH 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale Eva Rachel Retuya <eraretuya@gmail.com> - 2016-11-11 07:40 +0100
    Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Lars-Peter Clausen <lars@metafoo.de> - 2016-11-11 15:20 +0100
      Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Jonathan Cameron <jic23@kernel.org> - 2016-11-12 15:30 +0100
        Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Lars-Peter Clausen <lars@metafoo.de> - 2016-11-14 11:40 +0100
          Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-11-14 18:30 +0100
        Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Linus Walleij <linus.walleij@linaro.org> - 2016-11-14 18:00 +0100
          Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Lars-Peter Clausen <lars@metafoo.de> - 2016-11-14 20:00 +0100
            Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-11-14 23:20 +0100
            Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Linus Walleij <linus.walleij@linaro.org> - 2016-11-15 00:20 +0100
              Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Jonathan Cameron <jic23@kernel.org> - 2016-11-19 13:40 +0100
      Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Eva Rachel Retuya <eraretuya@gmail.com> - 2016-11-12 15:50 +0100
        Re: [PATCH 1/2] staging: iio: ad7606: replace range/range_available  with corresponding scale Lars-Peter Clausen <lars@metafoo.de> - 2016-11-14 11:30 +0100
  Re: [PATCH 2/2] staging: iio: ad7606: move out of staging Lars-Peter Clausen <lars@metafoo.de> - 2016-11-11 15:30 +0100
    Re: [PATCH 2/2] staging: iio: ad7606: move out of staging Jonathan Cameron <jic23@kernel.org> - 2016-11-12 15:30 +0100
      Re: [PATCH 2/2] staging: iio: ad7606: move out of staging Eva Rachel Retuya <eraretuya@gmail.com> - 2016-11-12 15:40 +0100
        Re: [PATCH 2/2] staging: iio: ad7606: move out of staging Jonathan Cameron <jic23@kernel.org> - 2016-11-12 15:50 +0100

csiph-web