Groups > linux.kernel > #1519483

Re: [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT
Date	2016-11-11 01:40 +0100
Message-ID	<sC82R-5nR-7@gated-at.bofh.it> (permalink)
References	<sC1b4-FQ-19@gated-at.bofh.it> <sC7gu-4O8-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 10, 2016 at 03:47:07PM -0800, Guenter Roeck wrote:
> On Thu, Nov 10, 2016 at 10:19:36AM -0700, Jason Gunthorpe wrote:
> > This compliments the existing scheme that lets it be set via
> > platform_data.
> > 
> > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> 
> I would prefer https://www.spinics.net/lists/devicetree/msg148819.html
> which appears to address the same problem and is less cryptic.

Is there a patch someplace that implements that proposed DT binding? I
couldn't find anything.

> NACK unless someone convinces me otherwise.

*shrug* both styles of definition seem to be used in various device
tree bindings.

The downside with Mahoda's proposal is that it only covers 3 of the 8
configuration bits, and will require alot of code for parsing. It
seems really clunky, and why is a regulator involved to set the A/D
sensitivity? Weird.

But I only need has-temp3, so if a patch appears please cc me and I'll
review it here..

Regards,
Jason

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-10 18:20 +0100
  Re: [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT Guenter Roeck <linux@roeck-us.net> - 2016-11-11 00:50 +0100
    Re: [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-11 01:40 +0100

csiph-web