Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519436

RE: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count

Show all headers | View raw

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, November 10, 2016 11:09 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; Stephen Hemminger
> <sthemmin@microsoft.com>; Alex Ng (LIS) <alexng@microsoft.com>; Alex
> Ng (LIS) <alexng@microsoft.com>
> Subject: Re: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show
> max page count
> 
> On Tue, Nov 01, 2016 at 01:07:28PM -0700, kys@exchange.microsoft.com
> wrote:
> > From: Alex Ng <alexng@messages.microsoft.com>
> >
> > Balloon driver was only printing the size of the info blob and not the
> > actual content. This fixes it so that the info blob (max page count as
> > configured in Hyper-V) is printed out.
> >
> > Signed-off-by: Alex Ng <alexng@microsoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/hv_balloon.c |    9 +++++++--
> >  1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> > index 8cac29a..14c3dc4 100644
> > --- a/drivers/hv/hv_balloon.c
> > +++ b/drivers/hv/hv_balloon.c
> > @@ -1034,8 +1034,13 @@ static void process_info(struct
> hv_dynmem_device *dm, struct dm_info_msg *msg)
> >
> >  	switch (info_hdr->type) {
> >  	case INFO_TYPE_MAX_PAGE_CNT:
> > -		pr_info("Received INFO_TYPE_MAX_PAGE_CNT\n");
> > -		pr_info("Data Size is %d\n", info_hdr->data_size);
> > +		if (info_hdr->data_size == sizeof(__u64)) {
> > +			__u64 *max_page_count = (__u64 *)&info_hdr[1];
> 
> Why __u64 instead of u64?  Is this code shared with user space?

__u64 was being used in other parts of this code already and I decided to follow that.

I wasn't aware of this distinction between the two.
This code is not shared in user-space, so perhaps we should clean up this file in a future patch.

Thanks for bringing it up.

> 
> regards,
> dan carpenter
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 00/14] Drivers: hv: Some miscellaneous fixes and enhancements  kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    Re: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show  max page count Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-10 20:20 +0100
      RE: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show  max page count "Alex Ng (LIS)" <alexng@microsoft.com> - 2016-11-11 00:20 +0100
  [PATCH V2 04/14] Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 02/14] Drivers: hv: utils: reduce HV_UTIL_NEGO_TIMEOUT timeout kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 12/14] Drivers: hv: vmbus: Base host signaling strictly on the ring state kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 03/14] Drivers: hv: utils: Fix the mapping between host version and protocol to use kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 11/14] tools: hv: remove unnecessary header files and netlink related code kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 14/14] Drivers: hv: vmbus: On the read path cleanup the logic to interrupt the host kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 07/14] Drivers: hv: vss: Operation timeouts should match host expectation kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
  [PATCH V2 01/14] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() (v2) kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    [PATCH V2 10/14] tools: hv: fix a compile warning in snprintf kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    [PATCH V2 06/14] Drivers: hv: vss: Improve log messages. kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    [PATCH V2 09/14] tools: hv: remove unnecessary link flag kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    [PATCH V2 13/14] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host kys@exchange.microsoft.com - 2016-11-01 19:20 +0100
    [PATCH V2 05/14] Drivers: hv: balloon: Add logging for dynamic memory operations kys@exchange.microsoft.com - 2016-11-01 19:20 +0100

csiph-web