Groups > linux.kernel > #1519321

Re: [PATCH] firmware: fix async/manual firmware loading

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware: fix async/manual firmware loading
Date	2016-11-10 20:50 +0100
Message-ID	<sC3wd-2e1-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <sxZKx-5YO-1@gated-at.bofh.it> <sBHYK-3NU-25@gated-at.bofh.it> <sBZVE-8ak-35@gated-at.bofh.it> <sC05j-8tv-5@gated-at.bofh.it> <sC33c-22r-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 10, 2016 at 11:18 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 10, 2016 at 08:07:58AM -0800, Luis R. Rodriguez wrote:
>> >  It shouldn't be hard to figure out if a patch should be in stable or not...
>>
>> Well with the only caveat now that I am suggesting we consider remove
>> this logic completely as only 2 drivers were using it explicitly
>> (second argument to request_firmware_nowait() set to false), it seems
>> they had good reasons for it but ... this has been broken for ages and
>> we seem to be happy to compartamentalize the UMH further, its unclear
>> why we would want to expand and "fix" that instead of just removing
>> crap that never worked. Thoughts?
>
> Why would you want to remove stuff that works and people rely on?  Don't
> be foolish, you know we can't do that...

I was not advocating removing it if it had worked, I advocated
removing it if it truly was something that never worked.

 Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: fix async/manual firmware loading Yves-Alexis Perez <corsac@corsac.net> - 2016-10-30 16:00 +0100
  Re: [PATCH] firmware: fix async/manual firmware loading Yves-Alexis Perez <corsac@corsac.net> - 2016-10-30 18:30 +0100
    Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-09 21:40 +0100
      Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-09 23:10 +0100
        Re: [PATCH] firmware: fix async/manual firmware loading Yves-Alexis Perez <corsac@corsac.net> - 2016-11-10 08:00 +0100
  Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-09 21:50 +0100
    Re: [PATCH] firmware: fix async/manual firmware loading Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-10 17:00 +0100
      Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-10 17:10 +0100
        Re: [PATCH] firmware: fix async/manual firmware loading Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-10 20:00 +0100
          Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-10 20:50 +0100
            Re: [PATCH] firmware: fix async/manual firmware loading Yves-Alexis Perez <corsac@corsac.net> - 2016-11-10 22:10 +0100
              Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-10 22:30 +0100
        Re: [PATCH] firmware: fix async/manual firmware loading Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-10 20:20 +0100
          Re: [PATCH] firmware: fix async/manual firmware loading "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-11-10 20:50 +0100

csiph-web