Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517871
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks |
| Date | 2016-11-09 11:00 +0100 |
| Message-ID | <sBxPI-5yX-7@gated-at.bofh.it> (permalink) |
| References | <szujf-70x-7@gated-at.bofh.it> <szujg-70x-29@gated-at.bofh.it> <sBnQm-7DS-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote:
>
>
> On 11/03/2016 12:40 PM, Johan Hovold wrote:
> > Make sure to drop the references taken by of_get_child_by_name() and
> > bus_find_device() before returning from cpsw_phy_sel().
> >
> > Note that holding a reference to the cpsw-phy-sel device does not
> > prevent the devres-managed private data from going away.
> >
> > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...")
> > Cc: Mugunthan V N <mugunthanvnm@ti.com>
> > Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> > Cc: linux-omap@vger.kernel.org
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Thanks for the review. Note that David has already applied these, though.
Johan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net v2 0/4] net: fix device reference leaks Johan Hovold <johan@kernel.org> - 2016-11-03 18:50 +0100
[PATCH net v2 3/4] net: ethernet: ti: davinci_emac: fix device reference leak Johan Hovold <johan@kernel.org> - 2016-11-03 18:50 +0100
[PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks Johan Hovold <johan@kernel.org> - 2016-11-03 18:50 +0100
Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-09 00:20 +0100
Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks Johan Hovold <johan@kernel.org> - 2016-11-09 11:00 +0100
[PATCH net v2 1/4] phy: fix device reference leaks Johan Hovold <johan@kernel.org> - 2016-11-03 18:50 +0100
Re: [PATCH net v2 0/4] net: fix device reference leaks David Miller <davem@davemloft.net> - 2016-11-07 19:20 +0100
csiph-web