[PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4

From	Zhiyi Sun <zhiyisun@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4
Date	2016-11-09 08:40 +0100
Message-ID	<sBvEd-4gF-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There are rx_ring_num queues. Each queue will load xdp prog. So
bpf_prog_add() should add rx_ring_num to ref_cnt.

Signed-off-by: Zhiyi Sun <zhiyisun@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 12c99a2..d25e150 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2650,7 +2650,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog)
 	 */
 	if (priv->xdp_ring_num == xdp_ring_num) {
 		if (prog) {
-			prog = bpf_prog_add(prog, priv->rx_ring_num - 1);
+			prog = bpf_prog_add(prog, priv->rx_ring_num);
 			if (IS_ERR(prog))
 				return PTR_ERR(prog);
 		}
@@ -2680,7 +2680,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog)
 	}
 
 	if (prog) {
-		prog = bpf_prog_add(prog, priv->rx_ring_num - 1);
+		prog = bpf_prog_add(prog, priv->rx_ring_num);
 		if (IS_ERR(prog))
 			return PTR_ERR(prog);
 	}
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Zhiyi Sun <zhiyisun@gmail.com> - 2016-11-09 08:40 +0100
  Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Daniel Borkmann <daniel@iogearbox.net> - 2016-11-09 10:10 +0100
    Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Zhiyi Sun <zhiyisun@gmail.com> - 2016-11-09 10:50 +0100
      Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Daniel Borkmann <daniel@iogearbox.net> - 2016-11-09 11:30 +0100
        Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Brenden Blanco <bblanco@plumgrid.com> - 2016-11-09 18:10 +0100
          Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Daniel Borkmann <daniel@iogearbox.net> - 2016-11-09 20:10 +0100

csiph-web