Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517736

Re: [PATCH v2 00/12] mm: page migration enhancement for thp

Show all headers | View raw

On 08/11/16 10:31, Naoya Horiguchi wrote:
> Hi everyone,
> 
> I've updated thp migration patches for v4.9-rc2-mmotm-2016-10-27-18-27
> with feedbacks for ver.1.
> 
> General description (no change since ver.1)
> ===========================================
> 
> This patchset enhances page migration functionality to handle thp migration
> for various page migration's callers:
>  - mbind(2)
>  - move_pages(2)
>  - migrate_pages(2)
>  - cgroup/cpuset migration
>  - memory hotremove
>  - soft offline
> 
> The main benefit is that we can avoid unnecessary thp splits, which helps us
> avoid performance decrease when your applications handles NUMA optimization on
> their own.
> 
> The implementation is similar to that of normal page migration, the key point
> is that we modify a pmd to a pmd migration entry in swap-entry like format.
> 
> Changes / Notes
> ===============
> 
> - pmd_present() in x86 checks _PAGE_PRESENT, _PAGE_PROTNONE and _PAGE_PSE
>   bits together, which makes implementing thp migration a bit hard because
>   _PAGE_PSE bit is currently used by soft-dirty in swap-entry format.
>   I was advised to dropping _PAGE_PSE in pmd_present(), but I don't think
>   of the justification, so I keep it in this version. Instead, my approach
>   is to move _PAGE_SWP_SOFT_DIRTY to bit 6 (unused) and reserve bit 7 for
>   pmd non-present cases.

Thanks, IIRC

pmd_present = _PAGE_PRESENT | _PAGE_PROTNONE | _PAGE_PSE

AutoNUMA balancing would change it to

pmd_present = _PAGE_PROTNONE | _PAGE_PSE

and PMD_SWP_SOFT_DIRTY would make it

pmd_present = _PAGE_PSE

What you seem to be suggesting in your comment is that

pmd_present should be _PAGE_PRESENT | _PAGE_PROTNONE

Isn't that good enough?

For THP migration I guess we use

_PAGE_PRESENT | _PAGE_PROTNONE | is_migration_entry(pmd)


> 
> - this patchset still covers only x86_64. Zi Yan posted a patch for ppc64
>   and I think it's favorably received so that's fine. But there's unsolved
>   minor suggestion by Aneesh, so I don't include it in this set, expecting
>   that it will be updated/reposted.
> 
> - pte-mapped thp and doubly-mapped thp were not supported in ver.1, but
>   this version should work for such kinds of thp.
> 
> - thp page cache is not tested yet, and it's at the head of my todo list
>   for future version.
> 
> Any comments or advices are welcomed.

Balbir Singh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] mm: page migration enhancement for thp Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-08 00:40 +0100
  [PATCH v2 02/12] mm: mempolicy: add queue_pages_node_check() Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-08 00:50 +0100
  [PATCH v2 07/12] mm: thp: check pmd migration entry in common path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-08 01:00 +0100
    Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path kbuild test robot <lkp@intel.com> - 2016-11-08 01:30 +0100
      Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-08 02:30 +0100
    Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-11-10 09:40 +0100
      Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-10 10:20 +0100
    Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-10 10:30 +0100
      Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common  path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-10 10:40 +0100
      Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common path "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-11-10 10:40 +0100
    Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common path "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-11-10 10:30 +0100
  [PATCH v2 06/12] mm: thp: enable thp migration in generic path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-08 01:40 +0100
  Re: [PATCH v2 00/12] mm: page migration enhancement for thp Balbir Singh <bsingharora@gmail.com> - 2016-11-09 03:40 +0100
    Re: [PATCH v2 00/12] mm: page migration enhancement for thp Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-09 06:10 +0100
      Re: [PATCH v2 00/12] mm: page migration enhancement for thp Balbir Singh <bsingharora@gmail.com> - 2016-11-09 22:30 +0100
  Re: [PATCH v2 00/12] mm: page migration enhancement for thp Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-11-09 11:40 +0100
    Re: [PATCH v2 00/12] mm: page migration enhancement for thp Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-11-10 01:00 +0100
      Re: [PATCH v2 00/12] mm: page migration enhancement for thp Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-11-11 04:50 +0100

csiph-web