Re: [PATCH] nfsd: constify reply_cache_stats_operations structure

From	"J. Bruce Fields" <bfields@fieldses.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nfsd: constify reply_cache_stats_operations structure
Date	2016-11-08 21:50 +0100
Message-ID	<sBlvb-5XM-29@gated-at.bofh.it> (permalink)
References	<sbfln-6yx-1@gated-at.bofh.it> <sbssh-6gC-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 29, 2016 at 06:57:47AM -0400, Jeff Layton wrote:
> On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote:
> > reply_cache_stats_operations, of type struct file_operations, is
> > never
> > modified, so declare it as const.
> > 
> > Done with the help of Coccinelle.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> > 
> > ---
> >  fs/nfsd/nfsctl.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> > index 65ad016..3bc9693 100644
> > --- a/fs/nfsd/nfsctl.c
> > +++ b/fs/nfsd/nfsctl.c
> > @@ -217,7 +217,7 @@ static const struct file_operations
> > pool_stats_operations = {
> >  	.release	= nfsd_pool_stats_release,
> >  };
> >  
> > -static struct file_operations reply_cache_stats_operations = {
> > +static const struct file_operations reply_cache_stats_operations = {
> >  	.open		= nfsd_reply_cache_stats_open,
> >  	.read		= seq_read,
> >  	.llseek		= seq_lseek,
> > 
> 
> I'm pretty sure Bruce will pick this up for v4.9:

Except, for some reason it's been languishing in my inbox.  Apologies,
applying....

--b.

> 
> Reviewed-by: Jeff Layton <jlayton@poochiereds.net>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] nfsd: constify reply_cache_stats_operations structure "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-08 21:50 +0100

csiph-web