Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused
Date	2016-11-08 18:40 +0100
Message-ID	<sBixk-3SR-37@gated-at.bofh.it> (permalink)
References	<sBg2u-2e5-33@gated-at.bofh.it> <sBg2u-2e5-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> The fresh new serial driver for pxa produces warnings when
> CONFIG_PM_SLEEP is disabled:
>
> drivers/tty/serial/8250/8250_pxa.c:50:12: error: 'serial_pxa_resume' defined but not used [-Werror=unused-function]
> drivers/tty/serial/8250/8250_pxa.c:41:12: error: 'serial_pxa_suspend' defined but not used [-Werror=unused-function]
>
> This removes the #ifdef around the two functions and instead marks both
> as __maybe_unused, which is more robust and avoids the warning.
>
> Fixes: ab28f51c77cd ("serial: rewrite pxa2xx-uart to use 8250_core")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] serial: pxa2xx: remove __deprecated annotation Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
  [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-11-08 16:00 +0100
    Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 18:40 +0100

csiph-web