Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517424

Re: [PATCH] spi: rspi: avoid uninitialized variable access

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] spi: rspi: avoid uninitialized variable access
Date 2016-11-08 18:50 +0100
Message-ID <sBiGZ-3WR-7@gated-at.bofh.it> (permalink)
References <sBeWK-1y1-15@gated-at.bofh.it> <sBinD-3Pq-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Nov 08, 2016 at 05:20:50PM +0000, Chris Brandt wrote:
> Since I was CC-ed, I'll add in my opinion:

> While Geert already pointed out the spelling mistake (_in_or_our >> _in_or_out), since that function is only just for qspi versions, a better function name should have been "qspi_pio_transfer_in_or_out"

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: rspi: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-11-08 14:50 +0100
  RE: [PATCH] spi: rspi: avoid uninitialized variable access Chris Brandt <Chris.Brandt@renesas.com> - 2016-11-08 18:30 +0100
    Re: [PATCH] spi: rspi: avoid uninitialized variable access Mark Brown <broonie@kernel.org> - 2016-11-08 18:50 +0100
    Re: [PATCH] spi: rspi: avoid uninitialized variable access Geert Uytterhoeven <geert@linux-m68k.org> - 2016-11-08 19:40 +0100
  Applied "spi: rspi: avoid uninitialized variable access" to the spi tree Mark Brown <broonie@kernel.org> - 2016-11-09 16:10 +0100
  Re: [PATCH] spi: rspi: avoid uninitialized variable access Hiep Cao Minh <cm-hiep@jinso.co.jp> - 2016-11-10 11:10 +0100
    Re: [PATCH] spi: rspi: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-11-10 12:00 +0100
      Re: [PATCH] spi: rspi: avoid uninitialized variable access Hiep Cao Minh <cm-hiep@jinso.co.jp> - 2016-11-11 02:00 +0100

csiph-web