Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return cpuid leaf info

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return cpuid leaf info
Date	2016-11-08 16:20 +0100
Message-ID	<sBglP-2zG-13@gated-at.bofh.it> (permalink)
References	<sBaq5-76t-1@gated-at.bofh.it> <sBaq5-76t-27@gated-at.bofh.it> <sBbYS-8bd-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 8 Nov 2016, Borislav Petkov wrote:
> On Tue, Nov 08, 2016 at 04:52:27PM +0800, He Chen wrote:
> > +struct cpuid_regs {
> > +	u32 eax, ebx, ecx, edx;
> > +};
> 
> Why do you export this? It is used in cpuid.c only.

Because I asked for it. We should have this stuff in one place to avoid the
next name clash.

What's worse with that patch is, that it does two things in one go:

    - cleanup that whole cpuid_regs mess

    - add the new function

That should clearly be seperated into two patches.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/2] cpuid: Support AVX512_4VNNIW and AVX512_4FMAPS for KVM guest He Chen <he.chen@linux.intel.com> - 2016-11-08 10:00 +0100
  [PATCH v4 2/2] cpuid: add AVX512_4VNNIW and AVX512_4FMAPS instructions support He Chen <he.chen@linux.intel.com> - 2016-11-08 10:00 +0100
    Re: [PATCH v4 2/2] cpuid: add AVX512_4VNNIW and AVX512_4FMAPS  instructions support Borislav Petkov <bp@alien8.de> - 2016-11-08 11:40 +0100
  [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return cpuid leaf info He Chen <he.chen@linux.intel.com> - 2016-11-08 10:00 +0100
    Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return  cpuid leaf info Borislav Petkov <bp@alien8.de> - 2016-11-08 11:40 +0100
      Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return  cpuid leaf info Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 16:20 +0100

csiph-web