Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1517246

Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip

From Sekhar Nori <nsekhar@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip
Date 2016-11-08 15:50 +0100
Message-ID <sBfSN-2az-1@gated-at.bofh.it> (permalink)
References <szoxb-3eu-7@gated-at.bofh.it> <sBeN4-1uG-73@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tuesday 08 November 2016 07:01 PM, Linus Walleij wrote:
> On Thu, Nov 3, 2016 at 12:34 PM, Axel Haslam <ahaslam@baylibre.com> wrote:
> 
>> The gpiod framework uses the chip label to match a specific chip.
>> The davinci gpio driver, creates several chips using always the same
>> label, which is not compatible with gpiod.
>>
>> To allow platform data to declare gpio lookup tables, and for drivers
>> to use the gpiod framework, allocate unique label per registered chip.
>>
>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> 
> Sekhar/Kevin: can either of you review this patch?

The patch looks good to me.

Reviewed-by: Sekhar Nori <nsekhar@ti.com>

I am traveling and did not really test the patch.

Thanks,
Sekhar

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] gpio: davinci: Use unique labels for each gpio chip Axel Haslam <ahaslam@baylibre.com> - 2016-11-03 12:40 +0100
  Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 14:40 +0100
    Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip Sekhar Nori <nsekhar@ti.com> - 2016-11-08 15:50 +0100
  Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip Kevin Hilman <khilman@baylibre.com> - 2016-11-08 19:20 +0100
  Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip Linus Walleij <linus.walleij@linaro.org> - 2016-11-09 09:20 +0100

csiph-web