Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change

From	Heiko Stübner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change
Date	2016-11-08 14:30 +0100
Message-ID	<sBeDo-1rd-23@gated-at.bofh.it> (permalink)
References	<sBaJr-7rN-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Elaine,

Am Dienstag, 8. November 2016, 17:10:14 schrieb Elaine Zhang:
> If validity is not checked prior to clock rate change, clk_set_rate(
> cpu_clk, unsupported_rate) will return success, but the real clock rate
> change operation is prohibited in post clock change event. Alough post
> clock change event will report error due to unsupported clock rate is
> set, but this error message is ignored by clock framework.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>

looks good and thanks for catching this. Just a bureaucracy-question regarding 
the Signed-off-by lines, before I can apply the patch as I don't really know 
how Rocky fits into the picture.

I.e. was he the original patch author (the we should change the from) or a 
reviewer/tester for the fixed issue?


Thanks
Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: rockchip: validity should be checked prior to clock rate change Elaine Zhang <zhangqing@rock-chips.com> - 2016-11-08 10:20 +0100
  Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change Heiko Stübner <heiko@sntech.de> - 2016-11-08 14:30 +0100

csiph-web