Re: [PATCH v2] HID: udraw: Add support for the uDraw tablet for PS3

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] HID: udraw: Add support for the uDraw tablet for PS3
Date	2016-11-08 14:30 +0100
Message-ID	<sBeDn-1rd-9@gated-at.bofh.it> (permalink)
References	<szP4l-3GT-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 4 Nov 2016, Bastien Nocera wrote:

> This adds support for the THQ uDraw tablet for the PS3, as
> 4 separate device nodes, so that user-space can easily consume
> events coming from the hardware.
> 
> Note that the touchpad two-finger support is fairly unreliable,
> and a right-click can only be achieved with a two-finger tap
> with the two fingers slightly apart (about 1cm should be enough).
> 
> Tested-by: Bastien Nocera <hadess@hadess.net>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>

Hi Bastien,

overall the driver looks ok to me, thanks. Probably the only concern I'd 
have -- traditionally, we've always been naming drivers by the vendor, as 
it turned out that over time they get extended by adding support for 
multiple devices with the same vendor, and usually there is quite some 
overlap in shared code.

Hence I'd propose to call this driver hid-thq (if that's really the 
vendor's proper name, doesn't seem to be present in latest usb.ids 
release).

Thanks,

-- 
Jiri Kosina
SUSE Labs

Thread

[PATCH v2] HID: udraw: Add support for the uDraw tablet for PS3 Bastien Nocera <hadess@hadess.net> - 2016-11-04 17:00 +0100
  Re: [PATCH v2] HID: udraw: Add support for the uDraw tablet for  PS3 Jiri Kosina <jikos@kernel.org> - 2016-11-08 14:30 +0100
    Re: [PATCH v2] HID: udraw: Add support for the uDraw tablet for PS3 Bastien Nocera <hadess@hadess.net> - 2016-11-08 14:40 +0100

csiph-web