Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517162

Re: [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC

Show all headers | View raw

Am Dienstag, 8. November 2016, 20:31:55 schrieb Andy Yan:
> Hi Heiko:
> 
> On 2016年11月04日 16:00, Heiko Stuebner wrote:
> > Am Donnerstag, 3. November 2016, 20:40:48 CET schrieb Andy Yan:

> >> +	gic: interrupt-controller@32010000 {
> >> +		compatible = "arm,cortex-a15-gic";
> > 
> > compatible = "arm,gic-400"; ?
> > 
> >> +		interrupt-controller;
> >> +		#interrupt-cells = <3>;
> >> +		#address-cells = <0>;
> >> +
> >> +		reg = <0x32011000 0x1000>,
> >> +		      <0x32012000 0x1000>;
> > 
> > please provide all 4 register areas and also the interrupt (
> 
>      I only found 2 register areas in our rockchip linux 3.10 source
> code. And haven't found the interrupt. From the arm,gic bindings, the
> interrupt property is optional. So am not sure if we
> really need it here.

Devicetree is a hardware description, so it's not a factor if we "need" it but 
only if it is present in the hardware. And we really want this information to 
be complete, as these additional areas are necessary if someone wants to use 
the virtualization extensions the cortext-A7 does contain.

The gic is a very standard component and the gic400 used here should definitly 
have those two additional areas as well as the interrupt.

I think the memory areas are pretty standard and should be for the rk1108:
reg = <0x32011000 0x1000>,
      <0x32012000 0x1000>,
      <0x32014000 0x2000>,
      <0x32016000 0x2000>;

The TRM talks about 128 SPI and 3 PPI interrupts but the irq-list does not 
contain them, so this seems to be an error in the TRM, as the gic interrupt 
should be one of those PPI interrupts.


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Add basic support for support for Rockchip RK1108 SOC Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:30 +0100
  [PATCH 1/6] dt-bindings: rockchip-dw-mshc: add RK1108 dw-mshc description Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:40 +0100
    Re: [PATCH 1/6] dt-bindings: rockchip-dw-mshc: add RK1108 dw-mshc  description Rob Herring <robh@kernel.org> - 2016-11-10 20:00 +0100
  [PATCH 2/6] pinctrl: rockchip: add support for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:40 +0100
    Re: [PATCH 2/6] pinctrl: rockchip: add support for rk1108 Heiko Stübner <heiko@sntech.de> - 2016-11-03 17:00 +0100
    Re: [PATCH 2/6] pinctrl: rockchip: add support for rk1108 Linus Walleij <linus.walleij@linaro.org> - 2016-11-06 11:10 +0100
  [PATCH 3/6] clk: rockchip: add clock controller for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:40 +0100
    Re: [PATCH 3/6] clk: rockchip: add clock controller for rk1108 Shawn Lin <shawn.lin@rock-chips.com> - 2016-11-04 03:20 +0100
    Re: [PATCH 3/6] clk: rockchip: add clock controller for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-04 08:40 +0100
  [PATCH 5/6] ARM: add low level debug uart for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:50 +0100
    Re: [PATCH 5/6] ARM: add low level debug uart for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-04 08:40 +0100
      Re: [PATCH 5/6] ARM: add low level debug uart for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-04 09:00 +0100
        Re: [PATCH 5/6] ARM: add low level debug uart for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-04 09:10 +0100
  [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:50 +0100
    Re: [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC Heiko Stuebner <heiko@sntech.de> - 2016-11-04 09:10 +0100
      Re: [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC Andy Yan <andy.yan@rock-chips.com> - 2016-11-08 13:40 +0100
        Re: [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC Heiko Stübner <heiko@sntech.de> - 2016-11-08 14:30 +0100
    Re: [PATCH 4/6] ARM: dts: add basic support for Rockchip RK1108 SOC Heiko Stuebner <heiko@sntech.de> - 2016-11-04 09:10 +0100
  [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Andy Yan <andy.yan@rock-chips.com> - 2016-11-03 13:50 +0100
    Re: [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Heiko Stuebner <heiko@sntech.de> - 2016-11-04 11:10 +0100
      Re: [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation  board Andy Yan <andy.yan@rock-chips.com> - 2016-11-04 12:00 +0100
        Re: [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Heiko Stuebner <heiko@sntech.de> - 2016-11-04 12:20 +0100
    Re: [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation  board Rob Herring <robh@kernel.org> - 2016-11-10 20:00 +0100

csiph-web