Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517120

Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

>>
>>               /* Do we need to handle the stepping? */
>>               if (is_default_overflow_handler(wp))
>>                       step = 1;
>> -
>> -unlock:
>> -             rcu_read_unlock();
>>       }
>> +     if (min_dist > 0 && min_dist != -1) {
>> +             /* No exact match found. */
>> +             wp = slots[closest_match];
>> +             info = counter_arch_bp(wp);
>> +             info->trigger = addr;
>> +             perf_bp_event(wp, regs);
>> +     }
>
> Why don't we need to bother with the stepping in the case of a non-exact
> match?

Good catch. I think we do. I must have dropped that part somehow.

Pratyush, could you include the attached fixup in the next batch?

regards,
pavel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint  addresses Will Deacon <will.deacon@arm.com> - 2016-11-08 04:30 +0100
  Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses Pavel Labath <labath@google.com> - 2016-11-08 13:10 +0100
    Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint  addresses Pratyush Anand <panand@redhat.com> - 2016-11-09 18:40 +0100

csiph-web