Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517086

Re: [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode()

Show all headers | View raw

On Mon, 07 Nov 2016, Lyude wrote:
> There's no need to have multiple copies of the logic we use for checking
> whether or not we're in tablet mode, so just use
> hotkey_get_tablet_mode() when checking the initial state in
> hotkey_init_tablet_mode().

...

> @@ -3130,13 +3130,16 @@ hotkey_init_tablet_mode(void)
>  	/* For X41t, X60t, X61t Tablets... */
>  	if (acpi_evalf(hkey_handle, &res, "MHKG", "qd")) {
>  		tp_features.hotkey_tablet = TP_HOTKEY_TABLET_USES_MHKG;
> -		in_tablet_mode = !!(res & TP_HOTKEY_TABLET_MASK);
>  		type = "MHKG";
>  	}
>  
>  	if (!tp_features.hotkey_tablet)
>  		return 0;
>  
> +	res = hotkey_get_tablet_mode(&in_tablet_mode);
> +	if (res)
> +		return res;
> +

Won't this way of doing things cause the ACPI methods to be called
twice in a row?

The hotkey_init_tablet_mode() code does mode detection, and thus
hotkey_get_tablet_mode() must be kept in sync with it *anyway* (and not
the opposite), so it doesn't look like a very relevant maintenance
burden...

-- 
  Henrique Holschuh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function Lyude <lyude@redhat.com> - 2016-11-07 18:40 +0100
  [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode() Lyude <lyude@redhat.com> - 2016-11-07 18:40 +0100
    Re: [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in  hotkey_init_tablet_mode() Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-08 12:20 +0100
  [PATCH v4 3/3] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode Lyude <lyude@redhat.com> - 2016-11-07 18:40 +0100
    Re: [PATCH v4 3/3] thinkpad_acpi: Add support for X1 Yoga (2016)  Tablet Mode Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-08 12:10 +0100
  Re: [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into  separate function Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-08 12:00 +0100
  Re: [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function Daniel Martin <consume.noise@gmail.com> - 2016-11-09 12:20 +0100

csiph-web