Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518986

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 10 Nov 2016, Corinna Vinschen wrote:

> On Nov  8 11:33, Alexander Duyck wrote:
...
>> The question I would have is what is reading the device when it is in
>> this state.  The watchdog and any other functions that would read the
>> device should be disabled.
>>
>> One possibility could be a race between a call to igb_close and the
>> igb_suspend function.  We have seen some of those pop up recently on
>> ixgbe and it looks like igb has the same bug.  We should probably be
>> using the rtnl_lock to guarantee that netif_device_detach and the call
>> to __igb_close are completed before igb_close could possibly be called
>> by the network stack.
>
> Do you have a pointer to the related ixgbe patch, by any chance?
...
>> The thing is that a suspended device should not be accessed at all.
>> If we are accessing it while it is suspended then that is a bug.  If
>> you could throw a WARN_ON call in igb_rd32 to capture where this is
>> being triggered that might be useful.
>>
>>> - Otherwise assume it's actually a surprise removal.  In theory that
>>>   should somehow trigger a device removal sequence, kind of like
>>>   calling igb_remove, no?
>>
>> Well a read of the MMIO region while suspended is more of a surprise
>> read since there shouldn't be anything going on.  We need to isolate
>> where that read is coming from and fix it.
>
> That would be ideal, but the problem couldn't be reproduced yet apart
> from at a customer's customer site.  It's not clear yet if we can access
> the machine for further testing.

Here's the initial patch for igb I have, but it's on hold awaiting more
changes in ixgbe regarding AER.

-- 
Hisashi T Fujinaka - htodd@twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Cao jin <caoj.fnst@cn.fujitsu.com> - 2016-11-08 08:10 +0100
  Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Corinna Vinschen <vinschen@redhat.com> - 2016-11-08 17:50 +0100
    Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Hisashi T Fujinaka <htodd@twofifty.com> - 2016-11-08 18:30 +0100
      Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Corinna Vinschen <vinschen@redhat.com> - 2016-11-08 19:40 +0100
        Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Alexander Duyck <alexander.duyck@gmail.com> - 2016-11-08 20:40 +0100
          Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Cao jin <caoj.fnst@cn.fujitsu.com> - 2016-11-09 14:30 +0100
          Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Corinna Vinschen <vinschen@redhat.com> - 2016-11-10 10:40 +0100
            Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Hisashi T Fujinaka <htodd@twofifty.com> - 2016-11-10 14:50 +0100
              Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Corinna Vinschen <vinschen@redhat.com> - 2016-11-10 18:30 +0100
      Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead  of e1000_hw->hw_addr Hisashi T Fujinaka <htodd@twofifty.com> - 2016-11-08 19:40 +0100
  Re: [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Alexander Duyck <alexander.duyck@gmail.com> - 2016-11-09 17:30 +0100

csiph-web