Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518561

Re: [PATCH v3] z3fold: use per-page read/write lock

Show all headers | View raw

On Wed, 9 Nov 2016, Andi Kleen wrote:

> On Wed, Nov 09, 2016 at 02:33:04PM -0800, Andrew Morton wrote:
> > On Wed, 9 Nov 2016 11:55:31 +0100 Vitaly Wool <vitalywool@gmail.com> wrote:
> > 
> > > Subject: [PATCH v3] z3fold: use per-page read/write lock
> > 
> > I've rewritten the title to "mm/z3fold.c: use per-page spinlock"
> > 
> > (I prefer to have "mm" in the title to easily identify it as an MM
> > patch, and using "mm: z3fold: ..." seems odd when the actual pathname
> > conveys the same info.)
> 
> Still think it needs to be raw_spinlock_t, otherwise the build bug on
> on the header size will break again. 

raw spinlocks in mainline are not smaller than spinlocks, that's only true
for RT. What's smaller are arch spinlocks, but then they evade debugging as
well.

> Better would be to fix that build bug though

Indeed.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] z3fold: use per-page read/write lock Vitaly Wool <vitalywool@gmail.com> - 2016-11-09 12:00 +0100
  Re: [PATCH v3] z3fold: use per-page read/write lock Andrew Morton <akpm@linux-foundation.org> - 2016-11-09 23:40 +0100
    Re: [PATCH v3] z3fold: use per-page read/write lock Andi Kleen <andi@firstfloor.org> - 2016-11-10 00:10 +0100
      Re: [PATCH v3] z3fold: use per-page read/write lock Thomas Gleixner <tglx@linutronix.de> - 2016-11-10 00:30 +0100
      Re: [PATCH v3] z3fold: use per-page read/write lock Andrew Morton <akpm@linux-foundation.org> - 2016-11-10 01:40 +0100

csiph-web