Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518376

Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings

Show all headers | View raw

From: Philippe Reynes <tremyfr@gmail.com>
Date: Sun,  6 Nov 2016 15:02:32 +0100

> When moving from typhoon_get_settings to typhoon_getlink_ksettings
> in the commit f7a5537cd2a5 ("net: 3com: typhoon: use new api
> ethtool_{get|set}_link_ksettings"), we use a local variable supported
> but we forgot to update the struct ethtool_link_ksettings with
> this value.
> 
> We also initialize advertising to zero, because otherwise it may
> be uninitialized if no case of the switch (tp->xcvr_select) is used.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> Changelog:
> v2:
> - remove a duplicate "commit" in the commit log

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-11-06 15:10 +0100
  Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings David Miller <davem@davemloft.net> - 2016-11-09 19:30 +0100

csiph-web