Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518353

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

Show all headers | View raw

On Mon, Nov 7, 2016 at 5:44 PM, Reza Arbab <arbab@linux.vnet.ibm.com> wrote:
> When movable nodes are enabled, any node containing only hotpluggable
> memory is made movable at boot time.
>
> On x86, hotpluggable memory is discovered by parsing the ACPI SRAT,
> making corresponding calls to memblock_mark_hotplug().
>
> If we introduce a dt property to describe memory as hotpluggable,
> configs supporting early fdt may then also do this marking and use
> movable nodes.
>
> Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>
> ---
>  drivers/of/fdt.c | 6 ++++++
>  mm/Kconfig       | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index c89d5d2..2cf1d66 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1015,6 +1015,7 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,
>         const char *type = of_get_flat_dt_prop(node, "device_type", NULL);
>         const __be32 *reg, *endp;
>         int l;
> +       bool hotpluggable;
>
>         /* We are scanning "memory" nodes only */
>         if (type == NULL) {
> @@ -1034,6 +1035,7 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,
>                 return 0;
>
>         endp = reg + (l / sizeof(__be32));
> +       hotpluggable = of_get_flat_dt_prop(node, "linux,hotpluggable", NULL);

Memory being hotpluggable doesn't seem like a linux property to me.
I'd drop the linux prefix. Also, this needs to be documented.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/4] enable movable nodes on non-x86 configs Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-08 00:50 +0100
  [PATCH v6 1/4] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-08 00:50 +0100
    Re: [PATCH v6 1/4] powerpc/mm: allow memory hotplug into a memoryless node Michael Ellerman <mpe@ellerman.id.au> - 2016-11-10 02:40 +0100
  [PATCH v6 4/4] of/fdt: mark hotpluggable memory Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-08 00:50 +0100
    Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-08 21:00 +0100
    Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Rob Herring <robh+dt@kernel.org> - 2016-11-09 19:20 +0100
      Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-09 21:20 +0100
    Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Balbir Singh <bsingharora@gmail.com> - 2016-11-10 02:00 +0100
      Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-11-10 22:00 +0100
    Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory Balbir Singh <bsingharora@gmail.com> - 2016-11-11 02:20 +0100

csiph-web