Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1518203
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy |
| Date | 2016-11-09 15:30 +0100 |
| Message-ID | <sBC30-8sr-15@gated-at.bofh.it> (permalink) |
| References | <sBek2-1kJ-21@gated-at.bofh.it> <sBetH-1nU-13@gated-at.bofh.it> <sBC30-8sr-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Em Wed, Nov 09, 2016 at 11:28:11AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 08, 2016 at 10:08:31PM +0900, Namhyung Kim escreveu:
> > When horizontall scrolling is used in hierarchy mode, the folded signed
> > disappears at the right most column.
>
> Humm, this indeed shows the '+' folded signal after pressing ->, but it
> moves from the first to the third column :-\
>
> > +++ b/tools/perf/ui/browsers/hists.c
> > @@ -1381,8 +1381,14 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser,
> > }
> >
> > perf_hpp_list__for_each_format(entry->hpp_list, fmt) {
> > - ui_browser__write_nstring(&browser->b, "", 2);
> > - width -= 2;
Also why move this invariant to both branches?
> > + if (first) {
> > + ui_browser__printf(&browser->b, "%c ", folded_sign);
> > + width -= 2;
> > + first = false;
> > + } else {
> > + ui_browser__write_nstring(&browser->b, "", 2);
> > + width -= 2;
> > + }
> >
> > /*
> > * No need to call hist_entry__snprintf_alignment()
> > --
> > 2.10.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Namhyung Kim <namhyung@kernel.org> - 2016-11-08 14:10 +0100
[PATCH 4/4] perf hists: Fix column length on --hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-11-08 14:20 +0100
[PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-11-08 14:20 +0100
Re: [PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-11-09 15:30 +0100
Re: [PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-11-09 15:30 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-11-08 14:30 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-11-09 14:20 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-11-09 14:20 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-11-08 14:50 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Namhyung Kim <namhyung@kernel.org> - 2016-11-08 16:10 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-11-08 16:20 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-11-09 14:20 +0100
Re: [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-11-09 14:20 +0100
csiph-web