Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518142

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

Show all headers | View raw

On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote:
> On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote:
> > 
> > Hello, Bruce.
> > 
> > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote:
> > > 
> > > Apologies, just cleaning out old mail and finding some I should have
> > > responded to long ago:
> > > 
> > > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar wrote:
> > > > 
> > > > The workqueue "callback_wq" queues a single work item &cb->cb_work per
> > > > nfsd4_callback instance and thus, it doesn't require execution ordering.
> > > 
> > > What's "execution ordering"?
> > > 

AIUI, it means that jobs are always run in the order queued and are
serialized.

> > > We definitely do depend on the fact that at most one of these is running
> > > at a time.
> > 

We do?

> > If there can be multiple cb's and thus cb->cb_work's per callback_wq,
> > it'd need explicit ordering.  Is that the case?
> 

These are basically client RPC tasks, and the cb_work just handles the
submission into the client RPC state machine. Just because we're running
several callbacks at the same time doesn't mean that they need to be
strictly ordered. The client state machine can certainly handle running
these in parallel.

> Yes, there can be multiple cb_work's.
> 

Yes, but each is effectively a separate work unit. I see no reason why
we'd need to order them at all.

-- 
Jeff Layton <jlayton@poochiereds.net>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-08 22:40 +0100
  Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-11-09 00:00 +0100
    Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-09 02:30 +0100
      Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Jeff Layton <jlayton@poochiereds.net> - 2016-11-09 14:20 +0100
        Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Trond Myklebust <trondmy@primarydata.com> - 2016-11-09 16:10 +0100
          Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Jeff Layton <jlayton@poochiereds.net> - 2016-11-09 16:20 +0100
        Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-09 17:30 +0100
          Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Jeff Layton <jlayton@poochiereds.net> - 2016-11-09 18:40 +0100
            Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-09 20:50 +0100
              Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue "J. Bruce Fields" <bfields@fieldses.org> - 2016-11-09 21:30 +0100
                Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated  create_singlethread_workqueue Jeff Layton <jlayton@poochiereds.net> - 2016-11-09 23:40 +0100

csiph-web