Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1518110

[PATCH v2] leds: Add mutex protection in brightness_show()

Show all headers | View raw

Initially the claim about no need for lock in brightness_show()
was valid as the function was just returning unchanged
LED brightness.

After the addition of led_update_brightness() this is no longer
true, as the function can change the brightness if a LED class
driver implements brightness_get op. It can lead to races between
led_update_brightness() and led_set_brightness().

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Lunn <andrew@lunn.ch>
---
Changes since v1:
- added led_sysfs_is_disabled() check
- moved sprintf under mutex protection

 drivers/leds/led-class.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index b12f861..e472407 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -29,11 +29,23 @@ static ssize_t brightness_show(struct device *dev,
 		struct device_attribute *attr, char *buf)
 {
 	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	int ret;
 
-	/* no lock needed for this */
-	led_update_brightness(led_cdev);
+	mutex_lock(&led_cdev->led_access);
+
+	if (led_sysfs_is_disabled(led_cdev)) {
+		ret = -EBUSY;
+		goto unlock;
+	}
+
+	ret = led_update_brightness(led_cdev);
+	if (ret < 0)
+		goto unlock;
 
-	return sprintf(buf, "%u\n", led_cdev->brightness);
+	ret = sprintf(buf, "%u\n", led_cdev->brightness);
+unlock:
+	mutex_unlock(&led_cdev->led_access);
+	return ret;
 }
 
 static ssize_t brightness_store(struct device *dev,
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] leds: Add mutex protection in brightness_show() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-09 13:20 +0100

csiph-web